Skip to content

Build CMake on macOS if one is not preinstalled #81161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025

Conversation

MaxDesiatov
Copy link
Contributor

@MaxDesiatov MaxDesiatov commented Apr 29, 2025

We build CMake on all platforms (except Darwin for an unknown reason) if CMake is not preinstalled. Since CMake 4.0 regresses certain build configurations, there's currently no way to build on Darwin without installing an older CMake version 3.x manually. This can be simplified if we build a pinned version of CMake consistently on all platforms.

We build CMake on all platforms (except Darwin for an unknown reason) if CMake is not preinstalled. Since CMake 4.0 regresses certain build configurations, there's currently no way to build on Darwin without installed an older CMake version manually. This can be simplified if we build a pinned version of CMake consistently on all platforms.
@MaxDesiatov
Copy link
Contributor Author

@swift-ci test

@MaxDesiatov
Copy link
Contributor Author

@swift-ci build toolchain

@MaxDesiatov MaxDesiatov added build-script Area → utils: The build script cmake labels Apr 29, 2025
@MaxDesiatov MaxDesiatov requested a review from bnbarham April 29, 2025 15:06
Copy link
Contributor

@edymtt edymtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- hat should not regress the current behaviour in CI, since utils/update_checkout/update-checkout-config.json by default will not clone CMake on macOS, it will only have an effect if at desk users ask explicitly to have CMake checked out.

@MaxDesiatov MaxDesiatov requested a review from al45tair May 9, 2025 10:48
@MaxDesiatov MaxDesiatov merged commit 7db6c5d into main May 9, 2025
8 checks passed
@MaxDesiatov MaxDesiatov deleted the maxd/build-cmake-if-unavailable branch May 9, 2025 14:59
Catfish-Man pushed a commit that referenced this pull request May 15, 2025
We build CMake on all platforms (except Darwin for an unknown reason) if CMake is not preinstalled. Since CMake 4.0 regresses certain build configurations, there's currently no way to build on Darwin without installing an older CMake version 3.x manually. This can be simplified if we build a pinned version of CMake consistently on all platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-script Area → utils: The build script cmake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants