Skip to content

[cxx-interop] Remove a workaround for CoreGraphics module interface #81177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2025
Merged

[cxx-interop] Remove a workaround for CoreGraphics module interface #81177

merged 1 commit into from
Apr 30, 2025

Conversation

egorzhdan
Copy link
Contributor

CoreGraphics can now be rebuilt with C++ interop enabled, which makes this workaround obsolete.

rdar://150211857

@egorzhdan
[cxx-interop] Remove a workaround for CoreGraphics module interface
571bd8e 
CoreGraphics can now be rebuilt with C++ interop enabled, which makes this workaround obsolete.

rdar://150211857
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Apr 29, 2025
@egorzhdan egorzhdan requested a review from j-hui April 29, 2025 21:04
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

artemcm
artemcm approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@artemcm artemcm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

j-hui
j-hui approved these changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@j-hui j-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test macOS

@egorzhdan egorzhdan enabled auto-merge April 30, 2025 13:05
@egorzhdan egorzhdan mentioned this pull request Apr 30, 2025
Merged
@egorzhdan egorzhdan merged commit 1c1f43f into main Apr 30, 2025
4 of 5 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/coregraphics-workaround branch April 30, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm artemcm approved these changes

@j-hui j-hui j-hui approved these changes

@tshortli tshortli Awaiting requested review from tshortli tshortli is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egorzhdan @artemcm @j-hui