[Observation] Use independent locking since the runtime functions reference a symbol that is not emitted #81185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erence a symbol that is not emitted
phausler
force-pushed
the
pr/observation_independent_locking
branch
from
10561de to
e5ce709
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
|
Can we see this back ported to 6.1? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime functions for locking end up referencing a symbol that is not publicly emitted. This leads to broken linux builds.
Since that interface is not public and does not offer a stable mechanism and Synchronization cannot be used (due to it being a higher deployment target) instead it has to revert to implementing locking from scratch for all platforms.
This is mostly replicated from the swift-async-algorithms package and should be usable enough to accomplish the goals of this module.
Resolves rdar://150060874