[6.2] LifetimeDependenceDiagnostics: bug fixes and output clarity #81192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the type checker encounters incomplete type error, bail out early to avoid an assertion. (cherry picked from commit 36551e3)
Fix a simple typo that results in infinite recursion on invalid code. Fixes rdar://147470493 ([nonescapable] LifetimeDependenceInsertion: infinite recursion in VariableUseDefWalker.walkup with immortal setter) (cherry picked from commit c891d8a)
(cherry picked from commit 49755bd)
(cherry picked from commit 25e9cbf)
Ensure that we always issue a diagnostic on error, but avoid emitting any notes that don't have source locations. With implicit accessors and thunks, report the correct line number and indicate which accessor generates the error. Always check for debug_value users. Consistently handle access scopes across diagnostic analysis and diagnostic messages. (cherry picked from commit ec51286)
Add a note explaining that dependence on closure captures is not supported. Otherwise, the diagnostics are very confusing: "it depends on a closure capture; this is not yet supported" (cherry picked from commit 83b0ce1)
|
@swift-ci test |
tbkka
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LifetimeDependence type checking: avoid an assertion on error.
When the type checker encounters incomplete type error, bail out early to avoid
an assertion.
(cherry picked from commit 36551e3)
LifetimeDependenceDiagnostics: avoid infinite recursion on error
Fix a simple typo that results in infinite recursion on invalid code.
Fixes rdar://147470493 ([nonescapable] LifetimeDependenceInsertion: infinite
recursion in VariableUseDefWalker.walkup with immortal setter)
(cherry picked from commit c891d8a)
Refactor debugVarDecl so arguments also support debug_value users.
(cherry picked from commit 49755bd)
[NFC] SwiftCompilerSource: bridge Function.accessorKindName
(cherry picked from commit 25e9cbf)
LifetimeDependence: clarify diagnostics for many unusual cases.
Ensure that we always issue a diagnostic on error, but avoid emitting any notes that don't have source locations.
With implicit accessors and thunks, report the correct line number and indicate which accessor generates the error.
Always check for debug_value users.
Consistently handle access scopes across diagnostic analysis and diagnostic messages.
(cherry picked from commit ec51286)
LifetimeDependenceDiagnostics: note for unsupported closure capture
Add a note explaining that dependence on closure captures is not
supported. Otherwise, the diagnostics are very confusing:
"it depends on a closure capture; this is not yet supported"
(cherry picked from commit 83b0ce1)