Fix LifetimeDependenceScopeFixup: extend scopes enclosing coroutines #81207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the type checker encounters incomplete type error, bail out early to avoid an assertion.
Fix a simple typo that results in infinite recursion on invalid code. Fixes rdar://147470493 ([nonescapable] LifetimeDependenceInsertion: infinite recursion in VariableUseDefWalker.walkup with immortal setter)
Ensure that we always issue a diagnostic on error, but avoid emitting any notes that don't have source locations. With implicit accessors and thunks, report the correct line number and indicate which accessor generates the error. Always check for debug_value users. Consistently handle access scopes across diagnostic analysis and diagnostic messages.
Add a note explaining that dependence on closure captures is not supported. Otherwise, the diagnostics are very confusing: "it depends on a closure capture; this is not yet supported"
When a coroutine is extended because of a dependent lifetime, extend all scopes that enclose that coroutine even if the coroutine itself has no lifetime dependencies. Fixes rdar://150275147 (Invalid SIL after lifetime dependence fixup involving coroutines)
atrick
requested review from
eeckstein,
hborla,
slavapestov,
xedin and
jckarter
as code owners
|
@swift-ci smoke test |
meg-gupta
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a single-commit PR. Prior commits are from #81191, which is already on 6.2 but blocked by CI.
Fix LifetimeDependenceScopeFixup: extend scopes enclosing coroutines
When a coroutine is extended because of a dependent lifetime, extend all scopes
that enclose that coroutine even if the coroutine itself has no lifetime
dependencies.
Fixes rdar://150275147 (Invalid SIL after lifetime dependence fixup involving
coroutines)