🍒 [6.2] [cxx-interop] Allow C++ function templates to be instantiated with Swift closures #81214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ift closures Swift started to explicitly forbid the instantiation of C++ function templates with arbitrary types in swiftlang#77430, because many types cause the Swift compiler to crash. However, those checks prevented them from being instantiated with Swift closures (which were previously fine), causing a regression. This patch relaxes the convertTemplateArgument() function to also allow converting Swift function types, and adds some tests to make sure doing so is fine. This patch also does some cleanup of existing tests checking the instantiation of various types, and adds testing for C function pointers and Obj-C blocks. rdar://148124104 (cherry picked from commit 284de98)
|
@swift-ci please test |
|
@swift-ci please test macos |
Xazax-hun
approved these changes
May 4, 2025
j-hui
force-pushed
the
base-6.2/swift-function-as-template-arg
branch
from
15ffc80 to
3f8e9cd
Compare
|
@swift-ci please test |
DougGregor
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This patch relaxes the
convertTemplateArgument()function to also allow instantiating function templates with Swift closures, which was possible earlier to but incorrectly diagnosed as an error since #77430.This PR omits an [NFC] patch that converts a Boolean flag into a template argument.
Issue: rdar://148124104
Risk: low
Testing: added tests
Original PRs: #81016
Reviewer: @Xazax-hun