[6.2][concurrency] Fix an off by one error in generic handling in local capture checking code. #81220
+66
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pture checking code. Otherwise, we break memory safety by accessing a generic parameter that does not exist resulting in undefined behavior. rdar://150351351 (cherry picked from commit fb3c710)
|
@swift-ci test |
|
@swift-ci test windows platform |
hborla
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This is a patch originally by @DougGregor that eliminates an off by one error when we are performing checking of metatypes. The result is that we break memory safety by accessing a generic parameter that does not exist resulting in undefined behavior. My contribution here is just shepherding and creating the test case.
Scope: Eliminates an off by one error.
Resolves: rdar://150351351
Main PR: #81193
Risk: Low. This just fixes an off by one error.
Testing: Added compiler tests
Reviewer: @gottesmm