[Serialization] Delay all actions in the same module together. #8123
Conversation
Back in December DougG added code to delay the formation of generic environments until all declarations from a particular module had been deserialized, to avoid circular dependencies caused by too-eager deserialization of protocol members. This worked great for fully-built modules, but still had some problems with module merging, the phase of multi-file compilation where the "partial" swiftmodules that correspond to each source file in a target are loaded and remitted as a single swiftmodule. Fix this by picking one of the partial swiftmodules as the representative one for delayed actions, and wait until deserialization is complete for /all/ of the serialized ASTs in the same target to form the generic environments. rdar://problem/30984417
|
@swift-ci Please test |
|
Build failed |
|
@shahmishal The label job failed and that failed even the top-level job? :-( https://ci.swift.org/job/swift-PR-Linux/6353/ |
|
@swift-ci Please smoke test Linux |
|
Build failed |
|
@swift-ci Please smoke test macOS |
|
LGTM. I'm not a fan of radar numbers in identifiers in test code, but I won't insist you change it before checking it in. ;) |
jrose-apple
deleted the
serialization-multi-file-circularity-ad-infinitum
branch
|
Thanks. I wanted to make it clear that they were unrelated to the other types already in the test, and to discourage people from reusing them in future additions. Many of these circularity issues are order-dependent. |
|
I completely forgot about the multi-partial-module merging case. Thanks, @jrose-apple |
Back in December @DougGregor added code to delay the formation of generic environments until all declarations from a particular module had been deserialized, to avoid circular dependencies caused by too-eager deserialization of protocol members. This worked great for fully-built modules, but still had some problems with module merging, the phase of multi-file compilation where the "partial" swiftmodules that correspond to each source file in a target are loaded and remitted as a single swiftmodule. Fix this by picking one of the partial swiftmodules as the representative one for delayed actions, and wait until deserialization is complete for all of the serialized ASTs in the same target to form the generic environments.
rdar://problem/30984417