[Runtimes][CMake] Build Differentiation in new style. #81239

sookach · 2025-05-01T20:37:04Z

Builds differentiation as part of the supplemental libraries and also adds a module for finding the math overlay.

Adding initial pass at the differentiation build.

Findmath.cmake performs a platform dependent lookup for the necessary math overlay and adds it as an imported target against which Differentiation links.

Runtimes/Supplemental/cmake/modules/Findmath.cmake

Runtimes/Supplemental/Differentiation/CMakeLists.txt

compnerd · 2025-05-01T21:11:42Z

Runtimes/Supplemental/Differentiation/CMakeLists.txt

+  "$<$<COMPILE_LANGUAGE:Swift>:SHELL:-enable-experimental-feature MemberImportVisibility>"
+  $<$<AND:$<BOOL:${SwiftDifferentiation_ENABLE_LIBRARY_EVOLUTION}>,$<COMPILE_LANGUAGE:Swift>>:-enable-library-evolution>)
+
+if(SwiftDifferentiation_ENABLE_VECTOR_TYPES)


We should probably put the sources under a Sources directory. While that is not required for CMake to work properly, I think that it would be nice to have the layout be similar to other projects.

I'm not sure if I understand correctly your point -- are you suggesting to have a directory structure in which the sources are not mingled with the CMake code? For example

Supplemental

Differentiation

CMakeLists.txt

Sources

AnyDifferentiable.swift

...

Synchronization

CMakeLists.txt

Sources

...

cmake/modules

You would still have the intermingled CMakeLists.txt, but the idea is that we could have the same structure across all the libraries. I think that @etcwilde suggested that we do that subsequently, which I am fine with.

Runtimes/Supplemental/Differentiation/CMakeLists.txt

compnerd · 2025-05-01T21:13:33Z

Runtimes/Supplemental/cmake/modules/Findmath.cmake

+    math_LIBRARY math_INCLUDE_DIR)
+else()
+  # TODO: Windows
+  message(FATAL_ERROR "Findmath.cmake module search not implemented for targeted platform\n")


I think that we can simply default to $ENV{SDKROOT}/usr/lib/swift/windows/${SwiftSupplemental_ARCH_SUBDIR}.

Runtimes/Supplemental/Differentiation/CMakeLists.txt

compnerd · 2025-05-09T20:41:09Z

Runtimes/Supplemental/Differentiation/CMakeLists.txt

+  VERSION 6.1.0${BUILD_NUMBER})
+
+set(CMAKE_POSITION_INDEPENDENT_CODE YES)
+set(CMAKE_Swift_LANGUAGE_VERSION 5)


Do we set the language version for the other libraries?

compnerd · 2025-05-09T20:42:05Z

Runtimes/Supplemental/cmake/modules/Findmath.cmake

@@ -0,0 +1,95 @@
+#[=======================================================================[.rst:
+Findmath


We should consider renaming this. Findmath makes it sound like this is meant to configure libm.

I'm on board. Any suggestions?

Re-reading the implementation more carefully, it does seem that this is doing some amount of work to locate and setup libm, which is incorrect. This is target dependent and you should use CMAKE_MATH_LIBS in the INTERFACE_LINK_DEPENDENCIES if you need to setup the link to the math library. However, that said, it shouldn't be needed as the swiftmodule should handle the autolinking.

Perhaps FindSwiftMath is an option if this is meant to be a helper for the _math Swift module?

compnerd · 2025-05-10T02:32:51Z

Runtimes/Supplemental/cmake/modules/Findmath.cmake

@@ -0,0 +1,95 @@
+#[=======================================================================[.rst:
+Findmath


Re-reading the implementation more carefully, it does seem that this is doing some amount of work to locate and setup libm, which is incorrect. This is target dependent and you should use CMAKE_MATH_LIBS in the INTERFACE_LINK_DEPENDENCIES if you need to setup the link to the math library. However, that said, it shouldn't be needed as the swiftmodule should handle the autolinking.

Perhaps FindSwiftMath is an option if this is meant to be a helper for the _math Swift module?

compnerd · 2025-05-10T02:34:15Z

Runtimes/Supplemental/cmake/modules/Findmath.cmake

+  find_library(math_LIBRARY NAMES m)
+  if(math_STATIC)
+    add_library(math STATIC IMPORTED GLOBAL)
+  else()
+    add_library(math SHARED IMPORTED GLOBAL)
+  endif()
+  set_target_properties(math PROPERTIES
+    IMPORTED_LOCATION ${math_LIBRARY}
+    INTERFACE_INCLUDE_DIRECTORIES ${math_INCLUDE_DIR} ${math_GLIBC_DIR})


This is not entirely correct. As a concrete example, musl does not need to link against libm but that would still evaluate LINUX as true. In such a case, you might end up linking against libm from glibc and have two different libc implementation in the address space, which is UB.

…iation Signed-off-by: Andrew Sukach <[email protected]>

edymtt · 2025-05-14T17:46:18Z

Runtimes/Supplemental/Differentiation/CMakeLists.txt

+include(AvailabilityMacros)
+include(CatalystSupport)
+include(EmitSwiftInterface)
+include(ResourceEmbedding)


We also need InstallSwiftInterface to be able to call install_swift_interface

include(InstallSwiftInterface)

edymtt · 2025-05-15T15:49:43Z

Runtimes/Supplemental/Differentiation/CMakeLists.txt

+
+install(TARGETS swift_Differentiation
+  EXPORT SwiftSupplementalTargets
+  COMPONENT SwiftCore_runtime


I would suggest to match the same name we are using in #81310

Suggested change

COMPONENT SwiftCore_runtime

COMPONENT ${PROJECT_NAME}_runtime

sookach requested review from etcwilde, compnerd, edymtt and justice-adams-apple as code owners May 1, 2025 20:37

etcwilde and others added 2 commits May 1, 2025 13:46

[Runtimes][CMake] Add differentiation build

24b60e8

Adding initial pass at the differentiation build.

[Runtimes][CMake] Add Findmath.cmake and use it in Differentiation

66cebdd

Findmath.cmake performs a platform dependent lookup for the necessary math overlay and adds it as an imported target against which Differentiation links.

sookach force-pushed the pr/runtimes-differentiation branch from 469f815 to 66cebdd Compare May 1, 2025 20:48

edymtt reviewed May 1, 2025

View reviewed changes

compnerd reviewed May 1, 2025

View reviewed changes

sookach force-pushed the pr/runtimes-differentiation branch from fe5fc68 to 34fda7d Compare May 1, 2025 21:45

edymtt mentioned this pull request May 5, 2025

[stdlib][CMake] Build differentiation in new runtime build #80513

Closed

edymtt reviewed May 5, 2025

View reviewed changes

Runtimes/Supplemental/Differentiation/CMakeLists.txt Show resolved Hide resolved

sookach force-pushed the pr/runtimes-differentiation branch from 34fda7d to 1598787 Compare May 7, 2025 01:37

sookach requested a review from edymtt May 7, 2025 01:39

compnerd reviewed May 9, 2025

View reviewed changes

compnerd reviewed May 10, 2025

View reviewed changes

fixup! [Runtimes][CMake] Add Findmath.cmake and use it in Different…

904db9b

…iation Signed-off-by: Andrew Sukach <[email protected]>

sookach force-pushed the pr/runtimes-differentiation branch from 1598787 to 904db9b Compare May 12, 2025 22:22

edymtt reviewed May 14, 2025

View reviewed changes

edymtt reviewed May 15, 2025

View reviewed changes

edymtt mentioned this pull request May 15, 2025

[Runtimes][CMake] Add Distributed to Supplemental build #81529

Open

		@@ -0,0 +1,95 @@
		#[=======================================================================[.rst:
		Findmath

	COMPONENT SwiftCore_runtime
	COMPONENT ${PROJECT_NAME}_runtime

[Runtimes][CMake] Build Differentiation in new style. #81239

Are you sure you want to change the base?

[Runtimes][CMake] Build Differentiation in new style. #81239

Uh oh!

Conversation

sookach commented May 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

edymtt May 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

compnerd May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

edymtt May 5, 2025 •

edited

Loading

compnerd May 1, 2025 •

edited

Loading