Skip to content

[cxx-interop] Remove symbolic import mode #81257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

egorzhdan
Copy link
Contributor

Importing C++ class templates in symbolic mode has proven to be problematic in interaction with other compiler features, and it isn't used widely. This change removes the feature.

rdar://150528798

Importing C++ class templates in symbolic mode has proven to be problematic in interaction with other compiler features, and it isn't used widely. This change removes the feature.

rdar://150528798
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan
Copy link
Contributor Author

@swift-ci please test Linux

Copy link
Contributor

@j-hui j-hui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

I recently added a few tests to the test/Interop/ sub-tree whose -index-store-path argument is no longer meaningful, so we can probably remove those too (but not necessarily in this patch).

@egorzhdan
Copy link
Contributor Author

@j-hui thanks! I'll remove those in a follow-up patch.

@egorzhdan egorzhdan merged commit 294e4cf into main May 5, 2025
5 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/remove-symbolic-mode branch May 5, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants