RangeInfo: Rework the criterion for valid selection of multiple statements, i.e. they should have a common brace statement as parent. #8129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments, i.e. they should have a common brace statement as parent.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
jrose-apple
reviewed
Mar 16, 2017
| @@ -320,6 +320,11 @@ static bool hasUnhandledError(ArrayRef<ASTNode> Nodes) { | |||
| }); | |||
| } | |||
|
|
|||
| static bool | |||
| hasNodeThat(ArrayRef<ASTNode> Nodes, llvm::function_ref<bool(ASTNode)> Pred) { | |||
There was a problem hiding this comment.
This is any_of in STLExtras.
There was a problem hiding this comment.
No, I mean llvm::any_of is just your hasNodeThat with generics.
There was a problem hiding this comment.
If that's the case, I still prefer it extracted to avoid typing begin() and end().
There was a problem hiding this comment.
llvm::any_of(StartMatches, IsCase). It's the same thing you have now.
|
|
||
| // Multi-statement should have a common parent of brace statement, this | ||
| // can be implicit brace statement, e.g. in case statement. | ||
| if (Parent.isStmt(StmtKind::Brace)) |
There was a problem hiding this comment.
Where's the part that checks if they're all the same parent?
There was a problem hiding this comment.
The is implied in ContextInfo; they won't end up here if they are not siblings.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @jrose-apple .