[NFC] cleanup Instruction/Value.findVarDecl() APIs #81290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
|
@swift-ci smoke test |
atrick
changed the title
atrick
force-pushed
the
lifedep-comment-typo
branch
from
7853def to
0f67711
Compare
|
@swift-ci smoke test |
eeckstein
approved these changes
May 6, 2025
SwiftCompilerSources/Sources/Optimizer/FunctionPasses/LifetimeDependenceScopeFixup.swift
Outdated
Show resolved
Hide resolved
These APIs are quite convoluted. The checks for var_decl need to be performed in just the right order. The is a consequence of complexity in the SIL representation itself, not a problem with the APIs. It is common for code to accidentally call a less-complete form of the API. It is essential that they be defined in a central location, and the we get the same answer whether we start with an Instruction, Argument, or Value. The primary public interface should always check for debug_value users. The varDecl property is actually an implementation detail. It is questionable whether a function like findVarDecl() that returns a basic property of SIL and does not require arguments should be a property instead. It is a function to hint that it may scan the use-list, which is not something we normally want SIL properties to do. Use-lists can grow linearly in function size. But, again, this is a natural result of the SIL representation and needs to be considered an implementation detail.
atrick
force-pushed
the
lifedep-comment-typo
branch
from
0f67711 to
170c563
Compare
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.