[Dependency Scanning] Emit a detailed error diagnostic on Clang module variant discovery #81313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcm
requested review from
cachemeifyoucan,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hborla,
slavapestov,
xedin and
tshortli
as code owners
|
@swift-ci test |
beccadax
approved these changes
May 5, 2025
cyndyishida
reviewed
May 6, 2025
There was a problem hiding this comment.
a few nits but overall looks good & thank you!
seemingly due to differences in Clang Scanner direct by-name queries and transitive header lookup queries.
I don't know if every case can be attributed to that, for example, there is one case where we don't have a reproducer but it didn't seem like there was a search issue since the modulemaps resolve the same but still have different hashes.
…e variant discovery In expectation, this should never happen. Such a situation means that within the same scanning action, Clang Dependency Scanner has produced two different variants of the same module. This is not supposed to happen, but we are currently hunting down the rare cases where it does, seemingly due to differences in Clang Scanner direct by-name queries and transitive header lookup queries.
artemcm
force-pushed
the
DepScanVariantError
branch
from
c3dce5b to
4b26a3d
Compare
Unfortunately, yes. |
|
@swift-ci smoke test |
cyndyishida
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In expectation, this should never happen. Such a situation means that within the same scanning action, Clang Dependency Scanner has produced two different variants of the same module. This is not supposed to happen, but we are currently hunting down the rare cases where it does, seemingly due to differences in Clang Scanner direct by-name queries and transitive header lookup queries.