[6.2][swift-settings] Now that we aren't using it immediately, remove it from tree. #81334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
DougGregor
previously approved these changes
May 6, 2025
|
@swift-ci test |
DougGregor
approved these changes
May 6, 2025
…rom tree. We can always get it back from the git history. rdar://150695113 (cherry picked from commit 9d59dbe) Conflicts: include/swift/AST/DiagnosticsSema.def include/swift/Basic/Features.def test/abi/macOS/arm64/concurrency.swift test/abi/macOS/x86_64/concurrency.swift
gottesmm
force-pushed
the
release/6.2-rdar150695113
branch
from
9631eb6 to
741e667
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This patch just removes SwiftSettings support from 6.2 since we aren't using it anymore. It also ensures that we do not expose any new ABI as a result of the stdlib part of this feature. If we ever need this we can always get it back from the git history.
Scope: Remove unused code. By removing this we do not expose the code to any users and also ensure that the stdlib part of this feature does not expose any ABI that we would have to maintain indefinitely.
Resolves: rdar://150695113
Main PR: #81306, #81336
Risk: Low. This just reverts a feature that we decided to do a different way. It was not enabled by default and but did expose some ABI which was not relied on by any users.
Testing: N/A
Reviewer: @compnerd