Skip to content

[Distributed] pointer auth protocol pointers as we use conformsToProtocol #81372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 9, 2025
+20 −2
Merged

[Distributed] pointer auth protocol pointers as we use conformsToProtocol #81372

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7152c7
[Distributed] pointer auth protocol pointers as we use conformsToProt…
ktoso May 8, 2025
e4c0c79
Apply suggestions from code review
ktoso May 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions lib/IRGen/GenDistributed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "GenDecl.h"
#include "GenMeta.h"
#include "GenOpaque.h"
#include "GenPointerAuth.h"
#include "GenProto.h"
#include "GenType.h"
#include "IRGenDebugInfo.h"
Expand Down Expand Up @@ -588,9 +589,26 @@ static llvm::Value *lookupWitnessTable(IRGenFunction &IGF, llvm::Value *witness,
assert(Lowering::TypeConverter::protocolRequiresWitnessTable(protocol));

auto &IGM = IGF.IGM;
auto *protocolDescriptor = IGM.getAddrOfProtocolDescriptor(protocol);
llvm::Value *protocolDescriptor = IGM.getAddrOfProtocolDescriptor(protocol);

bool signedProtocolDescriptor = IGM.getAvailabilityRange().isContainedIn(
IGM.Context.getSignedConformsToProtocolAvailability());

auto conformsToProtocolFunctionPointer = signedProtocolDescriptor ?
IGM.getConformsToProtocol2FunctionPointer() :
IGM.getConformsToProtocolFunctionPointer();

// Sign the protocol descriptor.
auto schema = IGF.IGM.getOptions().PointerAuth.ProtocolDescriptorsAsArguments;
if (schema && signedProtocolDescriptor) {
auto authInfo = PointerAuthInfo::emit(
IGF, schema, nullptr,
PointerAuthEntity::Special::ProtocolDescriptorAsArgument);
protocolDescriptor = emitPointerAuthSign(IGF, protocolDescriptor, authInfo);
}

auto *witnessTable = IGF.Builder.CreateCall(
IGM.getConformsToProtocolFunctionPointer(), {witness, protocolDescriptor});
conformsToProtocolFunctionPointer, {witness, protocolDescriptor});

auto failBB = IGF.createBasicBlock("missing-witness");
auto contBB = IGF.createBasicBlock("");
Expand Down