Skip to content

Reenable build of compiler-rt with LLVM_ENABLE_RUNTIMES in Linux bots... #81386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented May 8, 2025

...we disabled in #81354

This requires a couple of supporting changes

  • under Linux, do not cross compile LLVM when building for the host
    architecture -- that will ensure that the compiler-rt build will use
    the just built compiler and not the system one (which may not be
    new enough for this purpose);
  • provide sanitizer flags depending on the linker the just built compiler
    will use -- this detection is brittle, so print a message advising the
    user how to override this.

Addresses rdar://150849329

@edymtt
Copy link
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Ubuntu 24.04 aarch64

@edymtt
Copy link
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Ubuntu 22.04 aarch64

@edymtt
Copy link
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Amazon Linux 2 aarch64

@edymtt
Copy link
Contributor Author

edymtt commented May 8, 2025

@swift-ci please build toolchain Amazon Linux 2

@edymtt edymtt force-pushed the edymtt/do-not-crosscompile-llvm-under-linux branch from 1a797a0 to ff1c471 Compare May 9, 2025 16:22
@edymtt
Copy link
Contributor Author

edymtt commented May 9, 2025

@swift-ci please smoke test

@edymtt
Copy link
Contributor Author

edymtt commented May 9, 2025

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented May 9, 2025

Please test with following pull request:
swiftlang/swift-package-manager#8647

@swift-ci please build toolchain Amazon Linux 2

@edymtt
Copy link
Contributor Author

edymtt commented May 9, 2025

@swift-ci please build toolchain Ubuntu 22.04 aarch64

@edymtt
Copy link
Contributor Author

edymtt commented May 9, 2025

@swift-ci please build toolchain Ubuntu 24.04

@edymtt
Copy link
Contributor Author

edymtt commented May 9, 2025

@swift-ci Please Build Toolchain UBI9

@edymtt edymtt marked this pull request as ready for review May 9, 2025 16:37
@edymtt
Copy link
Contributor Author

edymtt commented May 12, 2025

@swift-ci Please Build Toolchain UBI9

@edymtt
Copy link
Contributor Author

edymtt commented May 12, 2025

@swift-ci please build toolchain Amazon Linux 2

...we disabled in swiftlang#81354

This requires a couple of supporting changes

* under Linux, do not cross compile LLVM when building for the host
 architecture -- that will ensure that the compiler-rt build will use
the just built compiler and not the system one (which may not be
new enough for this purpose);
* provide sanitizer flags depending on the linker the just built compiler
 will use -- this detection is brittle, so print a message advising the
user how to override this.

Addresses rdar://150849329
@edymtt edymtt force-pushed the edymtt/do-not-crosscompile-llvm-under-linux branch from ff1c471 to fcc0389 Compare May 13, 2025 16:14
@edymtt
Copy link
Contributor Author

edymtt commented May 13, 2025

@swift-ci please smoke test

@edymtt
Copy link
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain

@edymtt
Copy link
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain Amazon Linux 2

@edymtt
Copy link
Contributor Author

edymtt commented May 13, 2025

@swift-ci Please Build Toolchain UBI9

@edymtt
Copy link
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain Ubuntu 24.04

@edymtt
Copy link
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain Ubuntu 22.04 aarch64

@edymtt
Copy link
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain macOS

@edymtt
Copy link
Contributor Author

edymtt commented May 13, 2025

@swift-ci please build toolchain Ubuntu 22.04 aarch64

@edymtt edymtt merged commit a5261ae into swiftlang:main May 14, 2025
10 checks passed
hamishknight added a commit to hamishknight/swift that referenced this pull request May 22, 2025
…crosscompile-llvm-under-linux"

This reverts commit a5261ae.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant