Swiftify anonymous params rel #81399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_SwiftifyImport would expand with syntax errors if applied to a function with anonymous parameters, because it would try to refer to parameters using the name `_`. Detect these cases and create names for unnamed parameters. rdar://150955944 (cherry picked from commit 8e27947)
|
@swift-ci please test |
|
@swift-ci please test windows |
DougGregor
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the _SwiftifyImport macro to handle anonymous parameters, like can occur from imported C functions like
void foo(int __counted_by(len), int len), where the pointer parameter is unnamed. Before this change the macro expansion would try to refer to the parameter with_, resulting in syntax errors.This only affects code using the experimental SafeInteropWrappers feature flag.
rdar://150955944
[Swiftify] Handle anonymous parameters #81384
The risk should be low because it only affects code opting in to the experimental SafeInteropWrappers feature
Manual testing, lit tests
@DougGregor
This PR is stacked on top of #81388 to prevent conflicts.