Skip to content

[CSApply] Don't attempt to mark autoclosures as non-implicit #81422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xedin
Copy link
Contributor

@xedin xedin commented May 9, 2025

While building an initializer call the declaration reference should have the same implicitness as the call when it doesn't require thunking, otherwise don't attempt to mark autoclosures as non-implicit because it could break assumptions elsewhere.

While building an initializer call the declaration reference
should have the same implicitness as the call when it doesn't
require thunking, otherwise don't attempt to mark autoclosures
as non-implicit because it could break assumptions elsewhere.
@xedin xedin requested a review from AnthonyLatsis May 9, 2025 21:46
@xedin xedin requested review from ktoso and hborla as code owners May 9, 2025 21:46
@xedin
Copy link
Contributor Author

xedin commented May 9, 2025

@swift-ci please test

@xedin xedin merged commit 3b3d13c into swiftlang:main May 12, 2025
5 checks passed
Copy link
Collaborator

@AnthonyLatsis AnthonyLatsis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

hamishknight added a commit to hamishknight/swift that referenced this pull request May 22, 2025
…avoid-marking-autoclosure-closures-as-nonimplicit"

This reverts commit 3b3d13c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants