Sema: Allow T == NonCopyableOrEscapable same-type constraints without a redundant T: ~Copyable.
#81424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jckarter
requested review from
hborla,
slavapestov,
xedin and
kavon
as code owners
|
@swift-ci Please test |
slavapestov
reviewed
May 10, 2025
| @@ -802,15 +803,122 @@ void swift::rewriting::applyInverses( | |||
| ASTContext &ctx, | |||
| ArrayRef<Type> gps, | |||
| ArrayRef<InverseRequirement> inverseList, | |||
| ArrayRef<StructuralRequirement> explicitRequirements, | |||
There was a problem hiding this comment.
You can probably move this function into its own file because it’s horrible but also self-contained. That’s what I did with ConcreteContraction.cpp
|
@swift-ci Please test Windows |
jckarter
force-pushed
the
same-type-constraint-stop-copyable
branch
from
21a72bb to
0be2900
Compare
|
@swift-ci Please test |
slavapestov
approved these changes
May 12, 2025
|
Your change here also moves realizeInheritedRequirements() and StructuralRequirementsRequest::evaluate() to the new file. I was imagining it would just contain the applyInverses() function and nothing else (the circular dependency with RequirementLowering.cpp is fine). |
…ut a redundant `T: ~Copyable`. Enhance the logic in `applyInverses` to also take into account same-type constraints spelled in the generic signature, so that same-type-constraining a type parameter to a type that is itself not `Copyable` or `Escapable` suppresses the default application of those constraints on the type parameter. Fixes rdar://147757973.
jckarter
force-pushed
the
same-type-constraint-stop-copyable
branch
from
0be2900 to
e4a6faa
Compare
|
Sorry, I grabbed too much in my cut and paste. It should be fixed now. |
|
@swift-ci Please test |
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
May 22, 2025
…nstraint-stop-copyable" This reverts commit 52d7781.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance the logic in
applyInversesto also take into account same-type constraints spelled in the generic signature, so that same-type-constraining a type parameter to a type that is itself notCopyableorEscapablesuppresses the default application of those constraints on the type parameter. Fixes rdar://147757973.