[SR-2409] Rephrase diagnostic to consider Objective-C interop #8147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Objective-C interop is enabled, modules will continue to be referred to as “Objective-C modules”. But when interop is disabled, they will be referred to as “C modules”. Updated the existing test for the current behavior that doesn’t expect to fail on linux and doesn’t require objc_interop, so that it checks to different diagnostics on the two systems.
|
@swift-ci Please smoke test |
|
From the test output it looks like This is different than what's listed in the Testing Swift document, which is |
When swift-ci ran the tests, it looks like `%target-os` was "linux-gnu”, which wasn’t listed in the Testing Swift document (ony listing `macosx`, `darwin`, `linux`, `freebsd`, `windows-cygnus`, and `windows-gnu`) Since I can’t (at least don’t know how to) run the linux tests myself, I’ll try and update the check-prefix to see if that passes.
|
Ah, could you use |
|
Yes. That's probably closer to what I had intended. |
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
Looks great. Thanks, David! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR picks up where rephrase diagnostic #4587 left off, looking at the value of
EnableObjCInteropto choose between "C" and "Objective-C" as suggested by jrose-apple (in the conversation of that PR).It updates one of the tests to check for different results on macOS and on Linux, similar to the 32/64-bit example in the Testing Swift document.
Resolves SR-2409.