embedded: fix source location of diagnostics which appear in imported modules #81502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ug info Diagnostics only work with `SourceLoc` which is basically a pointer into a buffer of the loaded source file. But when debug info is de-serialized, the SIL `Location` consists of a filename+line+column. To "convert" this to a `SourceLoc`, the file must be loaded. This change adds `DiagnosticEngine.getLocationFromExternalSource` for this purpose. Also, the new protocol `ProvidingSourceLocation` - to which `SourceLoc` and `Location` conform - help to generalize the helper struct `Diagnostic` and make this "conversion" happen automatically.
This is important to get diagnostics for errors which are located in imported modules. Such errors can sometimes only be detected when building the client module, because the error can be in a generic function which is specialized in the client module. rdar://151162353
eeckstein
requested review from
artemcm,
tshortli,
hborla,
slavapestov,
xedin and
jckarter
as code owners
|
@swift-ci smoke test |
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
May 22, 2025
…in-embedded" This reverts commit 0d3edd6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In embedded swift, errors in imported modules can sometimes only be detected when building the client module, because the error can be in a generic function which is specialized in the client module.
To fix this, two changes are required:
rdar://151162353