[Swiftify] Don't create safe wrapper for autoreleasing pointers #81568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_SwiftifyImport doesn't know how to handle AutoreleasingUnsafeMutablePointer, so we should not attach any .countedBy information for pointers that are imported as this type. This also adds defensive checks against adding .countedBy to any pointer type that _SwiftifyImport doesn't know how to transform. rdar://151479521
hnrklssn
requested review from
zoecarver,
egorzhdan,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
beccadax and
ian-twilightcoder
as code owners
|
@swift-ci please smoke test |
j-hui
approved these changes
May 16, 2025
This test case fails on platforms without Objective-C interop. Move it to the ObjC directory, and add a local config that disables the entire subdirectory if Objective-C interop is missing.
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
1 similar comment
|
@swift-ci please smoke test linux |
hnrklssn
added a commit
to hnrklssn/swift
that referenced
this pull request
May 18, 2025
…tlang#81568) _SwiftifyImport doesn't know how to handle AutoreleasingUnsafeMutablePointer, so we should not attach any .countedBy information for pointers that are imported as this type. This also adds defensive checks against adding .countedBy to any pointer type that _SwiftifyImport doesn't know how to transform. rdar://151479521 (cherry picked from commit e1eb960)
hnrklssn
added a commit
that referenced
this pull request
May 20, 2025
…) (#81590) _SwiftifyImport doesn't know how to handle AutoreleasingUnsafeMutablePointer, so we should not attach any .countedBy information for pointers that are imported as this type. This also adds defensive checks against adding .countedBy to any pointer type that _SwiftifyImport doesn't know how to transform. rdar://151479521
hamishknight
added a commit
to hamishknight/swift
that referenced
this pull request
May 22, 2025
…rs (swiftlang#81568)" This reverts commit e1eb960.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_SwiftifyImport doesn't know how to handle AutoreleasingUnsafeMutablePointer, so we should not attach any .countedBy information for pointers that are imported as this type.
This also adds defensive checks against adding .countedBy to any pointer type that _SwiftifyImport doesn't know how to transform.
rdar://151479521