Skip to content

[stdlib] Adopt @_inheritActorContext(always) on Task.immediate #81572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xedin
Copy link
Contributor

@xedin xedin commented May 16, 2025

This change aligns implementation with the current SE-0472 proposal.

@xedin xedin requested review from a team and ktoso as code owners May 16, 2025 20:45
@xedin
Copy link
Contributor Author

xedin commented May 16, 2025

@swift-ci please test

This change aligns implementation with the current SE-0472 proposal.
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, we may want to make the function always emit into client actually!

@xedin
Copy link
Contributor Author

xedin commented May 17, 2025

@swift-ci please test Linux platform

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented May 18, 2025

@swift-ci please test Linux platform

@xedin xedin force-pushed the adopt-inheritActorContextAlways-in-Task-APIs branch from 85eff41 to 8c43330 Compare May 19, 2025 21:31
@xedin
Copy link
Contributor Author

xedin commented May 19, 2025

@swift-ci please test

xedin added 2 commits May 19, 2025 18:01
…icitSelfCapture`

Since the "operation" inherits the context of the actor it should
also be possible to reference its members without explicit use of
`self.`.
@xedin xedin force-pushed the adopt-inheritActorContextAlways-in-Task-APIs branch from 8c43330 to 0598b8c Compare May 20, 2025 01:01
@xedin
Copy link
Contributor Author

xedin commented May 20, 2025

@swift-ci please test

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, perfect now, lgtm

@xedin xedin merged commit a64984a into swiftlang:main May 20, 2025
5 checks passed
hamishknight added a commit to hamishknight/swift that referenced this pull request May 22, 2025
…torContextAlways-in-Task-APIs"

This reverts commit a64984a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants