[6.2][Concurrency] Diagnose loss of global actor isolation in async functi… #81577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on conversions Perform `Sendable` checking on parameter/result of the function type when conversion between asynchroneous functions results in a loss of global actor isolation attribute because access would result in data crossing an isolation boundary. This is a warning until Swift language mode 6. Resolves: rdar://130168104 (cherry picked from commit a058ffc)
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
hborla
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…on conversions
Cherry-pick of #81418
Explanation:
Perform
Sendablechecking on parameter/result of the function type when conversion between asynchronous functions results in a loss of global actor isolation attribute because access would result in data crossing an isolation boundary.This is a warning until Swift language mode 6.
Main Branch PR: [Concurrency] Diagnose loss of global actor isolation in async functi… #81418
Risk: Medium (All new diagnostics are downgraded to warnings but there could be existing code with Swift 6 mode that uses constructs that would produce new errors).
Reviewed By: @hborla
Resolves: rdar://130168104
Testing: Added new tests to the suite.
(cherry picked from commit a058ffc)