[Swiftify] Always annotate overloads with @_disfavoredOverload #81579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnrklssn
requested review from
Xazax-hun,
zoecarver,
egorzhdan,
j-hui,
fahadnayyar and
susmonteiro
as code owners
|
@swift-ci please smoke test |
|
@swift-ci please smoke test linux |
|
@swift-ci please smoke test |
hnrklssn
force-pushed
the
swiftify-disfavor-overload
branch
from
0776462 to
7922b5f
Compare
|
@swift-ci please smoke test |
hnrklssn
force-pushed
the
swiftify-disfavor-overload
branch
from
7922b5f to
371630b
Compare
|
@swift-ci please smoke test |
j-hui
approved these changes
May 21, 2025
There was a problem hiding this comment.
This change LGTM, but I recommend some testing/sign-off from someone familiar with SourceKit to make sure this doesn't have any unintended consequences, i.e., tools behaving differently when encountering decls with @_disfavoredOverload in such a way that is bad for dev experience
egorzhdan
approved these changes
May 21, 2025
|
@swift-ci please smoke test macos |
hnrklssn
force-pushed
the
swiftify-disfavor-overload
branch
from
371630b to
4c438db
Compare
|
This is now stacked on top of #81550 to avoid further merge conflicts, since both PRs have been approved separately. |
|
@swift-ci please smoke test |
This was referenced May 23, 2025
Previously we would only add @_disfavoredOverload if the only type changed was the return type, because in any other case it is unambiguous which overload to call. However it is still ambiguous when storing the function as a value rather than calling the function, unless explicit type annotations are used. To avoid breaking any existing code, this patch adds @_disfavoredOverload to every overload generated by @_SwiftifyImport. rdar://151206394
hnrklssn
force-pushed
the
swiftify-disfavor-overload
branch
from
4c438db to
9c4c0c4
Compare
|
@swift-ci please smoke test |
hnrklssn
added a commit
to hnrklssn/swift
that referenced
this pull request
May 29, 2025
…lang#81579) Previously we would only add @_disfavoredOverload if the only type changed was the return type, because in any other case it is unambiguous which overload to call. However it is still ambiguous when storing the function as a value rather than calling the function, unless explicit type annotations are used. To avoid breaking any existing code, this patch adds @_disfavoredOverload to every overload generated by @_SwiftifyImport. rdar://151206394 (cherry picked from commit 0f312ad)
hnrklssn
added a commit
to hnrklssn/swift
that referenced
this pull request
May 29, 2025
…lang#81579) Previously we would only add @_disfavoredOverload if the only type changed was the return type, because in any other case it is unambiguous which overload to call. However it is still ambiguous when storing the function as a value rather than calling the function, unless explicit type annotations are used. To avoid breaking any existing code, this patch adds @_disfavoredOverload to every overload generated by @_SwiftifyImport. rdar://151206394 (cherry picked from commit 0f312ad)
hnrklssn
added a commit
to hnrklssn/swift
that referenced
this pull request
May 31, 2025
…lang#81579) Previously we would only add @_disfavoredOverload if the only type changed was the return type, because in any other case it is unambiguous which overload to call. However it is still ambiguous when storing the function as a value rather than calling the function, unless explicit type annotations are used. To avoid breaking any existing code, this patch adds @_disfavoredOverload to every overload generated by @_SwiftifyImport. rdar://151206394 (cherry picked from commit 0f312ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would only add @_disfavoredOverload if the only type changed was the return type, because in any other case it is unambiguous which overload to call. However it is still ambiguous when storing the function as a value rather than calling the function, unless explicit type annotations are used.
To avoid breaking any existing code, this patch adds @_disfavoredOverload to every overload generated by @_SwiftifyImport.
rdar://151206394