[6.2] IRGen: fix failing unconditional class casts #81631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
May 20, 2025
eeckstein
commented
- Explanation: When unconditionally casting from a base to a final derived class, e.g. base as! Derived, the program did not abort with a trap. Instead the resulting null-pointer caused a crash later in the program. This fix inserts a trap condition for the failing case of such a cast.
- Risk: Low. It adds conditional traps for code which would have crashed anyway.
- Testing: Tested by lit tests.
- Issue: rdar://151462303
- Reviewer: @mikeash, @aschwaighofer
- Main branch PR: IRGen: fix failing unconditional class casts #81603
…ConditionalTrap` NFC
When unconditionally casting from a base to a final derived class, e.g. `base as! Derived`, the program did not abort with a trap. Instead the resulting null-pointer caused a crash later in the program. This fix inserts a trap condition for the failing case of such a cast. rdar://151462303
|
@swift-ci test |
tbkka
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.