[6.2][Concurrency] Infer @preconcurrency @MainActor in default main acto…
#81641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r mode for language modes < 6 `@MainActor` errors are hard errors, even in minimal concurrency checking in Swift 5 mode. When users set the default isolation to main actor, we should infer `@preconcurrency @MainActor` in language modes < 6 to get the right diagnostic staging behavior. Resolves: rdar://151029517 (cherry picked from commit 6561476)
|
@swift-ci please test |
hborla
approved these changes
May 20, 2025
|
@swift-ci please test Windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r mode for language modes < 6
Cherry-pick of #81627
Explanation:
@MainActorerrors are hard errors, even in minimal concurrency checking in Swift 5 mode. When users set the default isolation to main actor, we should infer@preconcurrency @MainActorin language modes < 6 to get the right diagnostic staging behavior.Main Branch PR: [Concurrency] Infer
@preconcurrency @MainActorin default main acto… #81627Risk: Low (New check downgrades errors to warnings in
-default-isolation MainActormode which allows more code to type-check).Reviewed By: @hborla
Resolves: rdar://151029517
Testing: Added new tests to the suite.
(cherry picked from commit 6561476)