Skip to content

[Runtimes][CMake] Rename SwiftCore target to swiftCore #81680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented May 21, 2025

This matches the case that we use in the Runtimes build system, so we rely the exported target instead of adding -lswiftCore.

Addresses rdar://151700669

This matches the case that we use in the Runtimes build system, so we
rely the exported target instead of adding `-lswiftCore`.

Addresses rdar://151700669
@edymtt
Copy link
Contributor Author

edymtt commented May 21, 2025

@swift-ci please smoke test

@edymtt edymtt enabled auto-merge May 21, 2025 16:17
@edymtt
Copy link
Contributor Author

edymtt commented May 21, 2025

macOS smoke test failed because in the Runtime build system we are using Swift.swiftmodule from the SDK instead of the one we just build

2025-05-21T16:46:48.767Z] /Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/Runtimes/Supplemental/StringProcessing/_StringProcessing/Unicode/NFC.swift:33:32: error: value of type 'String' has no member '_nfc'
[2025-05-21T16:46:48.767Z] 31 |     // SwiftStdlib is always >= 5.7 for a shipped StringProcessing.
[2025-05-21T16:46:48.767Z] 32 |     guard #available(SwiftStdlib 5.7, *) else { return nil }
[2025-05-21T16:46:48.767Z] 33 |     var nfcIter = String(self)._nfc.makeIterator()
[2025-05-21T16:46:48.767Z]    |                                `- error: value of type 'String' has no member '_nfc'
[2025-05-21T16:46:48.767Z] 34 |     guard let scalar = nfcIter.next(), nfcIter.next() == nil else { return nil }
[2025-05-21T16:46:48.767Z] 35 |     return scalar
[2025-05-21T16:46:48.767Z] /Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/swift/Runtimes/Supplemental/StringProcessing/_StringProcessing/Unicode/WordBreaking.swift:14:2: warning: '@_spi' import of 'Swift' will not include any SPI symbols; 'Swift' was built from the public interface at /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX15.2.sdk/usr/lib/swift/Swift.swiftmodule/arm64e-apple-macos.swiftinterface

Amending this in #81687

@edymtt
Copy link
Contributor Author

edymtt commented May 22, 2025

@swift-ci please smoke test

@edymtt edymtt merged commit 794fe00 into swiftlang:main May 22, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants