[6.2][CSApply] Don't inject global actor into closure type if it's marked … #81718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as `@concurrent` When the attribute is specified explicitly passing a `@concurrent` closure to a global actor-isolated parameter or contextual type should result in a conversion and closure itself should be nonisolated. Resolves: rdar://151797372 (cherry picked from commit efc6efc)
|
@swift-ci please test |
bnbarham
approved these changes
May 22, 2025
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…as
@concurrentCherry-pick of #81690
Explanation:
When the attribute is specified explicitly passing a
@concurrentclosure to a global actor-isolated parameter or contextual type should result in a conversion and closure itself should be nonisolated.Main Branch PR: [CSApply] Don't inject global actor into closure type if it's marked … #81690
Risk: Low (Applicable only to explicit use of
@concurrentattribute).Resolves: rdar://151797372
Reviewed By: @gottesmm
Testing: Added new tests to the suite.
(cherry picked from commit efc6efc)