Skip to content

[6.2][Driver] Add missing -default-isolation to the old driver #81731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

[6.2][Driver] Add missing -default-isolation to the old driver #81731

merged 1 commit into from
May 27, 2025

Conversation

bnbarham
Copy link
Contributor

@bnbarham bnbarham commented May 23, 2025 •
edited
Loading

  • Explanation: Passes -default-isolation through to the frontend from the old driver (which sourcekitd is still using).
  • Scope: Old driver (so really just sourcekitd)
  • Issues: rdar://151643763
  • Original PRs: [Driver] Add missing -default-isolation to the old driver #81729
  • Risk: Extremely low (if not none), just passes an existing flag through to the frontend (which is already the case for the new driver).
  • Testing: Checked they are now passed through
  • Reviewers: TBD

@bnbarham
[Driver] Add missing -default-isolation to the old driver
9bb3f58 
Resolves rdar://151643763.

(cherry picked from commit 0b7fbb6)
@bnbarham bnbarham requested a review from a team as a code owner May 23, 2025 02:16
@bnbarham
Copy link
Contributor Author

@swift-ci please test

@bnbarham
Copy link
Contributor Author

@swift-ci please test macOS platform

@bnbarham bnbarham merged commit 7667f03 into swiftlang:release/6.2 May 27, 2025
5 checks passed
@bnbarham bnbarham deleted the cherry-add-def-iso-to-old-driver branch May 27, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnbarham @hborla