[6.2][TypeChecker] Improve diagnostics for access to actor-isolated values… #81737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… outside of the actor Replaces generic `expression is 'async' but is not marked with 'await` diagnostic with a tailed one for cases where there is an access to an actor-isolated value outside of its actor without `await` keyword. This makes the diagnostics for async and sync contexts consistent and actually identifies a problem instead of simply pointing out the solution. Resolves: rdar://151720646 (cherry picked from commit 7a6ba8e)
|
@swift-ci please test |
hborla
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… outside of the actor
Cherry-pick of #81719
Explanation:
Replaces generic
expression is 'async' but is not marked with 'awaitdiagnostic with a tailed one for cases where there is an access to an actor-isolated value outside of its actor withoutawaitkeyword.This makes the diagnostics for async and sync contexts consistent and actually identifies a problem instead of simply pointing out the solution.
Main Branch PR: [TypeChecker] Improve diagnostics for access to actor-isolated values… #81719
Risk: Low (Diagnostic improvements only).
Resolves: rdar://151720646
Reviewed By: @hborla
Testing: Updated existing tests in the suite.
(cherry picked from commit 7a6ba8e)