Skip to content

[cxx-interop] Ensure consistent checks for exportable fields #81742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2025
Merged

[cxx-interop] Ensure consistent checks for exportable fields #81742

merged 1 commit into from
May 23, 2025

Conversation

susmonteiro
Copy link
Contributor

@susmonteiro susmonteiro commented May 23, 2025 •
edited
Loading

Small change requested here to make sure that we always go through isExportableField when determining if we should emit metadata for a field.

Follows #81035

@susmonteiro susmonteiro requested a review from rjmccall as a code owner May 23, 2025 14:28
@susmonteiro susmonteiro added the c++ interop Feature: Interoperability with C++ label May 23, 2025
@susmonteiro
Copy link
Contributor Author

@swift-ci please smoke test

egorzhdan
egorzhdan approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@egorzhdan egorzhdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@susmonteiro susmonteiro enabled auto-merge May 23, 2025 17:18
@susmonteiro susmonteiro merged commit aa396d8 into main May 23, 2025
3 checks passed
@susmonteiro susmonteiro deleted the susmonteiro/metadata-private-fields branch May 23, 2025 19:00
@susmonteiro susmonteiro mentioned this pull request May 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egorzhdan egorzhdan egorzhdan approved these changes

@DougGregor DougGregor Awaiting requested review from DougGregor

@rjmccall rjmccall Awaiting requested review from rjmccall rjmccall is a code owner

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susmonteiro @egorzhdan