[6.2] Make InferIsolatedConformances and StrictMemorySafety migratable features
#81744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
This is future-proofing the version part of the upcoming feature. There currently no features that require that but it's possible that they'd be added in the future. (cherry picked from commit 4909b9b)
When migrating, provide warnings that add 'nonisolated' to nonisolated conformances that don't already have it and would end up being inferred to be isolated under the upcoming feature. (cherry picked from commit a32782b)
This feature is essentially self-migrating, but fit it into the migration flow by marking it as migratable, adding `-strict-memory-safety:migrate`, and introducing a test. (cherry picked from commit abad2fa)
The name of a migratable feature might differ from the names of the diagnostic groups containing the diagnostics that are used to drive migration for that feature. Provide the set of diagnostic categories that are associated with each migratable feature as part of the supported features list. (cherry picked from commit 7f2649f)
(cherry picked from commit 2eeb394)
(cherry picked from commit 32267f4)
DougGregor
force-pushed
the
more-migratable-features-6.2
branch
from
bc76b04 to
589fd33
Compare
|
@swift-ci please test |
tbkka
approved these changes
May 29, 2025
Check for unsafe constructs in all modes, so that we can emit the "unsafe does not cover any unsafe constructs" warning consistently. One does not need to write "unsafe" outside of strict memory safety mode, but if you do... it needs to cover unsafe behavior. (cherry picked from commit 1b94c3b)
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InferIsolatedConformancesandStrictMemorySafetymigratable features #81703