[Distributed] account Distributed module use from DA declarations #81797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When issuing warnings about an import not needing to be public, we did not account for the Distributed module MUST be imported when a distributed actor is declared. This also actually means that a public distributed actor effectively is a public use of the DistributedActor protocol resolves rdar://152129980
|
@swift-ci please smoke test |
ktoso
commented
May 28, 2025
| // REQUIRES: distributed | ||
|
|
||
| // Should NOT produce a warning, we do use the module in a public declaration, see MyPublicDistributedActor | ||
| public import Distributed |
There was a problem hiding this comment.
We wrongly issued a "Public import of 'Distributed' was not used in public declarations or inlinable code" here before
|
@swift-ci please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When issuing warnings about an import not needing to be public, we did
not account for the Distributed module MUST be imported when a
distributed actor is declared. This also actually means that a public
distributed actor effectively is a public use of the DistributedActor
protocol
resolves rdar://152129980