Skip to content

Always print UUIDs using uppercase. #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 30, 2015
Merged

Always print UUIDs using uppercase. #819

merged 1 commit into from
Dec 30, 2015

Conversation

ezephir
Copy link

@ezephir ezephir commented Dec 30, 2015

This changes UUID::toString() to always print using upper case. The previous
behavior was platform specific, resulting in difficulty checking UUIDs in tests.
Serialization/basic_sil.swift and SIL/Parser/basic.sil are now expected to pass
on Linux. This resolves bug SR-417.

This changes UUID::toString() to always print using upper case. The previous
behavior was platform specific, resulting in difficulty checking UUIDs in tests.
Serialization/basic_sil.swift and SIL/Parser/basic.sil are now expected to pass
on Linux. This resolves bug SR-417.
@ezephir
Copy link
Author

ezephir commented Dec 30, 2015

Additional notes for the review:

  • The case that libuuid's unparse function uses seems to be defined at compile time.
  • On Ubuntu 14.04, this is compiled as lower case. In OS X 10.10, this is compiled in as upper case.
  • Parsing is unaffected by this change (upper, lower, and mixed case UUIDs still parse)

This change causes other platforms to conform with Swift's current behavior on OS X.

@lattner
Copy link
Contributor

lattner commented Dec 30, 2015

Nice!

lattner added a commit that referenced this pull request Dec 30, 2015
Always print UUIDs using uppercase.
@lattner lattner merged commit 83cff4e into swiftlang:master Dec 30, 2015
@ezephir ezephir deleted the basic-sil-linux branch December 30, 2015 19:44
MaxDesiatov pushed a commit to MaxDesiatov/swift that referenced this pull request May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants