[Distributed] Fix computed properties in protocols on arm64e #82009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Jun 5, 2025
| // We avoid emitting _distributed_get accessors, as they cannot be | ||
| // referred to anyway | ||
| continue; | ||
| } |
There was a problem hiding this comment.
Turns out this was overdoing it.
|
@swift-ci please smoke test |
xedin
reviewed
Jun 5, 2025
test/Distributed/Runtime/distributed_actor_localSystem_distributedProtocol.swift
Outdated
Show resolved
Hide resolved
This actually manifested as an pointer auth crash, but the real reason being is that we messed up the order of elements in the witness table. If we'd skip the accessor like this, the types we sign/auth with would no longer align and manifest in a crash. There is no real reason to skip this entry so we just bring it back, and avoid making this special in any way. This unlocks a few tests as well as corrects any distributed+protocol use where a requirement distributed var was _followed by_ other requirements. resolves rdar://125628060
ktoso
force-pushed
the
wip-fix-computed-variables-arm64-protocol-dist
branch
3 times, most recently
from
4553c29 to
328f110
Compare
|
@swift-ci please smoke test |
We had a number of problems either "only in" or "only without" library evolution and protocols, so in order to increase the test coverage, run a few of the crucial tests in both modes.
ktoso
force-pushed
the
wip-fix-computed-variables-arm64-protocol-dist
branch
from
328f110 to
cedcd4a
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test macOS |
|
@swift-ci please smoke test Linux |
xedin
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This actually manifested as an pointer auth crash, but the real reason being is that we messed up the order of elements in the witness table. If we'd skip the accessor like this, the types we sign/auth with would no longer align and manifest in a crash.
There is no real reason to skip this entry so we just bring it back, and avoid making this special in any way.
This unlocks a few tests as well as corrects any distributed+protocol use where a requirement distributed var was followed by other requirements.
Huge thanks to @xedin for help tracking this down.
resolves rdar://125628060