Skip to content

[6.2] [Sema] Tighten up function call check in resolveKeyPathExpr #82319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

hamishknight
Copy link
Contributor

6.2 cherry-pick of #82316

  • Explanation: Fixes a crash that could occur when attempting to use a postfix operator in a keypath, which is invalid.
  • Scope: Affects key paths
  • Issue: rdar://153671753
  • Risk: Low, this is logic that was introduced in 6.2. Furthermore this logic recurses on the function expression, which would have always produced an invalid result for operators.
  • Testing: Added tests to test suite
  • Reviewer: Pavel Yaskevich

@hamishknight hamishknight requested a review from bnbarham June 17, 2025 20:53
@hamishknight hamishknight requested a review from a team as a code owner June 17, 2025 20:53
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Jun 17, 2025
Check for `CallExpr` instead of `ApplyExpr`, we don't support
arbitrary postfix operators in key paths.
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit 612f7b2 into swiftlang:release/6.2 Jun 18, 2025
5 checks passed
@hamishknight hamishknight deleted the keyed-6.2 branch June 18, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants