[ConstraintSystem] Guard all the performance hacks with a flag #82320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's folded into a more general "disable performance hacks" one.
Package the flag into `performanceHacksEnabled()` method on `ConstraintSystem` and start using it to wrap all of the hacks in constraint generator and the solver.
xedin
requested review from
hborla,
slavapestov,
artemcm,
tshortli and
DougGregor
as code owners
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
|
@swift-ci please test macOS platform |
|
@swift-ci please test Windows platform |
1 similar comment
|
@swift-ci please test Windows platform |
hamishknight
approved these changes
Jun 19, 2025
|
@swift-ci please test macOS platform |
jamieQ
reviewed
Jun 23, 2025
Comment on lines
76
to
+77
| auto &ctx = getASTContext(); | ||
| assert(ctx.TypeCheckerOpts.DisableConstraintSolverPerformanceHacks || | ||
| !solverState->BestScore || CurrentScore <= *solverState->BestScore); | ||
| assert(!solverState->BestScore || CurrentScore <= *solverState->BestScore); |
There was a problem hiding this comment.
@xedin i noticed during a recent rebase & build that the ctx var is now marked unused after this change. was the new performanceHacksEnabled() method intended to continue to be consulted in this assertion, or is it safe to delete the now-unused var?
There was a problem hiding this comment.
It’s safe to remove the context variable!
jamieQ
added a commit
to jamieQ/swift
that referenced
this pull request
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package the flag into
performanceHacksEnabled()method onConstraintSystemand start using it to wrap all of the hacksin constraint generator and the solver.
Replace
-disable-solver-shrinkwith-disable-constraint-solver-performance-hacks.