[6.2][Concurrency] SE-0449: Fix a few issues related to nonisolated type declarations
#82324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…from protocol conformances. (cherry picked from commit 4fca62a)
…e kind is explicit. (cherry picked from commit 7e42a19)
…olated protocol (cherry picked from commit 82497af)
…make witnesses nonisolated Even if the requirement is stated on an isolated protocol if the conformance is implied by a nonisolated one all of the requirements and witnesses should be nonisolated. (cherry picked from commit 06be7bd)
…on inference from protocol requirements If a `nonisolated` type conforms to a global-isolated protocol the witnesses to the protocol requirements should infer the isolation from the protocol but instead be `nonisolated`. Resolves: rdar://145519840 (cherry picked from commit e50acbf)
hborla
approved these changes
Jun 17, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #79893, #82289
Explanation:
If the protocol from the conformance list explicitly strips off global actor with
nonisolated, make sure to look for this explicit isolation source when computing the resulting isolation; to prevent accidental global actor inference on the conforming type.If a
nonisolatedtype conforms to a global-isolated protocol the witnesses to the protocol requirements should infer the isolation from the protocol but instead benonisolated.Resolves: rdar://144798727, rdar://145519840
Main Branch PRs: [Concurrency] Look for explicit 'nonisolated' when getting isolation from protocol conformances. #79893, [Concurrency] SE-0449:
nonisolatedon a type should prevent isolati… #82289Risk: Low. The change affects only declarations that conform to
nonisolatedprotocols or declare asnonisolatedtype.Reviewed By: @ktoso @hborla
Testing: Added new test-cases to the Concurrency test suite.