Skip to content

[6.2] [CS] Distinguish locators for generic args in addSpecializationConstraint #82340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

hamishknight
Copy link
Contributor

6.2 cherry-pick of #82334

  • Explanation: Fixes a crash that could occur when using an unbound generic type in a macro generic argument
  • Scope: Affects type-checking generic arguments on references to macros + (invalid) functions
  • Issue: rdar://153674889
  • Risk: Low, the fix is straightforward
  • Testing: Added tests to test suite
  • Reviewer: Pavel Yaskevich

…raint`

Make sure we give each argument a different locator to ensure we
can correctly record any opened types.

rdar://153674889
@hamishknight hamishknight requested a review from bnbarham June 18, 2025 15:25
@hamishknight hamishknight requested a review from a team as a code owner June 18, 2025 15:25
@hamishknight hamishknight added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.2 labels Jun 18, 2025
@hamishknight
Copy link
Contributor Author

@swift-ci please test

@hamishknight hamishknight merged commit 8f66e61 into swiftlang:release/6.2 Jun 19, 2025
5 checks passed
@hamishknight hamishknight deleted the record-opened-6.2 branch June 19, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants