-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[6.2] Sema: Expand isolated conformance inference to consider conformances to inherited protocols #82384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
DougGregor
merged 1 commit into
swiftlang:release/6.2
from
slavapestov:implied-isolated-conformance-6.2
Jun 25, 2025
Merged
[6.2] Sema: Expand isolated conformance inference to consider conformances to inherited protocols #82384
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8239,16 +8239,28 @@ ActorIsolation swift::inferConformanceIsolation( | |
return nominalIsolation; | ||
} | ||
|
||
bool anyIsolatedWitness = false; | ||
auto protocol = conformance->getProtocol(); | ||
for (auto requirement : protocol->getMembers()) { | ||
if (isa<TypeDecl>(requirement)) | ||
|
||
// Also check the value witnesses of each implied conformance to every | ||
// inherited protocol, recursively. | ||
for (auto req : protocol->getRequirementSignature().getRequirements()) { | ||
if (req.getKind() != RequirementKind::Conformance || | ||
!req.getFirstType()->isEqual(protocol->getSelfInterfaceType())) | ||
continue; | ||
|
||
auto valueReq = dyn_cast<ValueDecl>(requirement); | ||
if (!valueReq) | ||
auto *assocConf = conformance->getAssociatedConformance( | ||
req.getFirstType(), req.getProtocolDecl()).getConcrete(); | ||
auto isolation = assocConf->getIsolation(); | ||
if (isolation.isGlobalActor()) | ||
return isolation; | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also a question raised by Doug Gregor here regarding the above |
||
|
||
bool anyIsolatedWitness = false; | ||
for (auto requirement : protocol->getProtocolRequirements()) { | ||
if (isa<TypeDecl>(requirement)) | ||
continue; | ||
|
||
auto valueReq = cast<ValueDecl>(requirement); | ||
auto witness = conformance->getWitnessDecl(valueReq); | ||
if (!witness) | ||
continue; | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
public protocol P { | ||
func f() | ||
} | ||
|
||
public protocol PDerived: P {} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 changes: 9 additions & 0 deletions
9
test/Concurrency/isolated_conformance_inference_with_default_actor.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
// RUN: %empty-directory(%t) | ||
// RUN: %target-swift-frontend -emit-module -emit-module-path %t/isolated_conformance_other.swiftmodule %S/Inputs/isolated_conformance_other.swift -swift-version 6 | ||
// RUN: %target-typecheck-verify-swift -I %t -swift-version 6 -enable-upcoming-feature InferIsolatedConformances -default-isolation MainActor -swift-version 6 | ||
// REQUIRES: swift_feature_InferIsolatedConformances | ||
|
||
import isolated_conformance_other | ||
|
||
struct S1: P { func f() {} } | ||
struct S2: PDerived { func f() {} } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't want this to get lost; see Doug Gregor's feedback on this code comment here: #82383 (comment)