[6.2][Concurrency] A few nonisolated(nonsending) fixes
#82432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tnesses If the requirement is `nonisolated(nonsending)` but witness is synchronous, prevent actor isolation inference from requirements because this isolation only applies to asynchronous declarations at the moment. Resolves: rdar://153680826 (cherry picked from commit a964282)
…t leave caller's isolation Make sure that referencing `nonisolated(nonsending)` properties, especially through a witness is as not treated as leaving the isolation domain of the caller. Resolves: rdar://153922620 (cherry picked from commit 35a41ab)
DougGregor
approved these changes
Jun 23, 2025
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #82382 and #82386
Explanation:
Fixes a few issues with
nonisolated(nonsending)attribute that were discovered in qualification:nonisolated(nonsending)on synchronous witnessesnonisolated(nonsending)properties don't leave caller's isolationResolves: rdar://153680826, rdar://153922620
Main branch PRs: [Concurrency] Don't infer
nonisolated(nonsending)on synchronous wi… #82382 and [Concurrency] References tononisolated(nonsending)properties don't… #82386Risk: Low. The feature is not enabled by default yet.
Reviewed By: @gottesmm and @ktoso
Testing: Added new test-cases into Concurrency test suite.