-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Caching] Put caching diagnostics into its own DiagnosticGroups #82507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Caching] Put caching diagnostics into its own DiagnosticGroups #82507
Conversation
@swift-ci please smoke test |
This documentation explains what caching is but doesn't help the developer address the diagnostics, which I think is the primary role of documentation under |
It kind of says how to address the issue in a subtle way. The thought behind this is that actually the diagnostics in swift caching are mostly safe guards when something go wrong, like:
There are generally no actionable item, other than:
On the other hand, if hit those errors, it can be quite confusing what to do. The diagnostics are trying to provide some path forward for debugging and workaround the issue when possible. Happy to work on the wording so that it can be better for this context. |
Maybe what you wrote above should be summarized in a section of the doc that is specifically about the diagnostics. For example, split it into two sections: the first being a high-level, brief overview of what caching is and the second being an explanation of potential sources of errors and what to do about them. |
Add explanation and documentation for swift caching diagnostics. rdar://154335823
729456a
to
65643a6
Compare
Document updated to be more error centric. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I think the revised version will be clearer for users!
Co-authored-by: Allan Shortlidge <[email protected]>
@swift-ci please smoke test |
@swift-ci please smoke test macOS platform |
Add explanation and documentation for swift caching diagnostics.
rdar://154335823