Skip to content

[IRGen] Sign these function pointers. #82510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

nate-chandler
Copy link
Contributor

Value witness tables for prespecialized metadata for multi payload enums contain references to swift_getMultiPayloadEnumTagSinglePayload and swift_storeMultiPayloadEnumTagSinglePayload. On platforms with ptrauth, those functions must be signed. Use the same helper when adding these functions to the table as is used to add every single other function to the table.

rdar://80334865

Value witness tables for prespecialized metadata for multi payload enums
contain references to `swift_getMultiPayloadEnumTagSinglePayload` and
`swift_storeMultiPayloadEnumTagSinglePayload`.  On platforms with
ptrauth, those functions must be signed.  Use the same helper when
adding these functions to the table as is used to add every single other
function to the table.

rdar://80334865
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler
Copy link
Contributor Author

@swift-ci please test macos platform

@nate-chandler
Copy link
Contributor Author

@swift-ci please test windows platform

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thank you!

@nate-chandler nate-chandler marked this pull request as ready for review June 26, 2025 19:02
@nate-chandler nate-chandler merged commit 76fd747 into swiftlang:main Jun 26, 2025
5 checks passed
@nate-chandler nate-chandler deleted the rdar80334865 branch June 26, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants