Skip to content

[6.2] [SILGen] Ensure that we don't emit a skipped isolated deinit #82546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DougGregor
Copy link
Member

  • Explanation: Use of isolated deinit with Objective-C-derived classes would crash when generating a Swift module, because SILGen would attempt to emit the definition even when it was deliberately skipped. Align the logic here so we don't emit the definition when it's not needed.
  • Scope: Limited to Swift module file generation when using the new nonisolated deinit feature.
  • Issues: rdar://154373088 / issue Swift Compiler crash with isolated deinit #82523
  • Original PRs: [SILGen] Ensure that we don't emit a skipped isolated deinit #82545
  • Risk: Very low. Targeted fix for a new feature.
  • Testing: CI, new project
  • Reviewers: @ktoso

@DougGregor DougGregor requested a review from a team as a code owner June 26, 2025 21:11
@DougGregor
Copy link
Member Author

@swift-ci please test

@DougGregor
Copy link
Member Author

@swift-ci please test macOS

@DougGregor DougGregor enabled auto-merge June 26, 2025 22:50
@DougGregor DougGregor merged commit 5373f52 into swiftlang:release/6.2 Jun 27, 2025
5 checks passed
@DougGregor DougGregor deleted the silgen-skip-isolated-deinit-6.2 branch June 27, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants