[DestroyAddrHoisting] Don't fold into read access. #82557
Merged
+48
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narrowly fix a long-standing bug where destroy_addrs would be hoisted into read access scopes, leaving the scope as a read despite the fact that it modifies memory. This is a problem for utilities which expect access scopes to provide correct summaries. Do this by refusing to fold into access scopes which are marked `[read]`. In a follow-up, we can reenable this folding, promoting each access scope to a modify. Doing so requires checking that there are no access scopes which overlap with any of the access scopes which would be promoted to modify. rdar://154407327
|
@swift-ci please test |
|
@swift-ci please apple silicon benchmark |
|
@swift-ci please test windows platform |
1 similar comment
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Narrowly fix a long-standing bug where
destroy_addrs would be hoisted into read access scopes, leaving the scope as a read despite the fact that it modifies memory. This is a problem for utilities which expect access scopes to provide correct summaries. Do this by refusing to fold into access scopes which are marked[read].In a follow-up, we can reenable this folding, promoting each access scope to a modify. Doing so requires checking that there are no access scopes which overlap with any of the access scopes which would be promoted to modify.
rdar://154407327