Sema: Don't construct naked ErrorTypes in valid code #8341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is useful to set a breakpoint on ErrorType::get(ASTContext) to see what is going wrong immediately instead of after the fact when an ErrorType pops up where you don't expect it. Unfortunately associated type inference, domain shrinking and the type cleanup RAII utility would all build ErrorTypes even with valid code. Refactor things a bit so that this is no longer the case; at least now the standard library and overlays build with 'assert(false)' inserted into ErrorType::get(ASTContext). ErrorType::get(Type) is still expected to come up in associated type inference since it is used as a signal while sorting through potential type witness candidates.
|
@swift-ci Please smoke test |
|
@brentdax It's all yours :) |
|
The code in here is subsumed by #8642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is useful to set a breakpoint on ErrorType::get(ASTContext)
to see what is going wrong immediately instead of after the
fact when an ErrorType pops up where you don't expect it.
Unfortunately associated type inference, domain shrinking and
the type cleanup RAII utility would all build ErrorTypes even
with valid code.
Refactor things a bit so that this is no longer the case; at
least now the standard library and overlays build with
'assert(false)' inserted into ErrorType::get(ASTContext).
ErrorType::get(Type) is still expected to come up in associated
type inference since it is used as a signal while sorting
through potential type witness candidates.