[SILOptimizer]Refactor ObjC dependencies in sil_combine tests #835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move functionality that requires ObjC interop into a new file and remove the XFAIL on Linux. Partially resolves SR-216.
|
After researching, I've moved cast_of_class_to_int to the ObjC since it's testing Foundation-related behavior. Therefore:
This PR is up to date and ready for merging or new feedback. |
|
The change LGTM. @gribozavr Can we accept this pull request? |
|
@nadavrot Thank you for the review! I just wanted to run tests -- they pass on OS X and Linux. |
gribozavr
added a commit
that referenced
this pull request
Jan 4, 2016
[SILOptimizer]Refactor ObjC dependencies in sil_combine tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves functionality that requires ObjC interop into a new file.
Partially resolves SR-216.
This was tested on OS X 10.10 and Ubuntu 14.04
Questions for this review:
I'm awaiting feedback on pull request #832 on issues that apply here. I'll update this PR (if necessary) based on that feedback.