Pass CLANG_VERSION_* cmake flags to the LLVM build. #8393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Example: |
|
Looks reasonable to me. |
|
Oops, need to update the tests! |
In a normal swiftless clang build, if it doesnt know CLANG_VERSION_*, clang's cmake falls back on LLVM_VERSION_*. We pass a CLANG_COMPILER_VERSION to swift, but it is not necessarily what clang wants to know. The intention of this CLANG_VERSION_* flag in Clang is to know what Swift calls clang_user_visible_version. This is the non-specific version of Clang. For example, clang-900 - this is 9.0.0, while Swift would like clang_compiler_version to be the specific version that the driver will print out. Flag naming! Fix tests
zisko
force-pushed
the
what-clang-doesnt-know-will-hurt-it
branch
from
2053658 to
2647ca2
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@zisko The way to check the tests locally is with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a normal swiftless clang build, if clang doesnt know CLANG_VERSION_*,
clang's cmake falls back on LLVM_VERSION_*. We pass a CLANG_COMPILER_VERSION
to swift, but it is not necessarily what clang wants to know.
The intention of this CLANG_VERSION_* flag in Clang is to know
what Swift calls clang_user_visible_version. This is the non-specific
version of Clang. For example, clang-900 - clang_user_visible_version is 9.0.0,
while Swift would like clang_compiler_version to be the specific version that the
driver will print out.
See above
Resolves SR-NNNN.
rdar://30452142