SIL: Terminology change: [fragile] => [serialized] #8407
Conversation
|
@swift-ci Please test |
slavapestov
force-pushed
the
rename-everything-without-asking-permission
branch
2 times, most recently
from
073a136 to
31ddabb
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
| // Serialized if referenced from another serialized function. | ||
| IsSerializable, | ||
| // Always serialized. | ||
| IsSerialized |
There was a problem hiding this comment.
IMHO, IsSerialized is not a very good choice for a name. It is too easy to think that something was serialized by the SIL serializer already. I'd prefer names which would use a different verb. Or they could indicate the possibility, e.g. NotToBeSerialized, CanBeSerialized, ShouldBeSerialized....
There was a problem hiding this comment.
It's better than "fragile" no? :-)
There was a problem hiding this comment.
Yes, it is better than "fragile", but not good enough, IMHO ;-)
|
@swift-ci Please smoke test |
Also, add a third [serializable] state for functions whose bodies we *can* serialize, but only do so if they're referenced from another serialized function. This will be used for bodies synthesized for imported definitions, such as init(rawValue:), etc, and various thunks, but for now this change is NFC.
slavapestov
force-pushed
the
rename-everything-without-asking-permission
branch
from
31ddabb to
8fe8b89
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please test Linux |
|
Build failed |
|
@swift-ci Please smoke test Linux |
|
First a flaky SwiftPM test now Foundation, neither related to my change which is NFC. Sigh. |
|
@swift-ci Please smoke test Linux |
|
@shahmishal @erg Can one of you guys just click the magic merge button? This patch is just a giant NFC renaming and delaying it for another day will just mean more fixing merge conflicts and rebasing. |
Also, add a third [serializable] state for functions whose bodies we
can serialize, but only do so if they're referenced from another
serialized function.
This will be used for bodies synthesized for imported definitions,
such as init(rawValue:), etc, and various thunks, but for now this
change is NFC.